[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: renaming "vertical spacing inside systems" props
From: |
Keith E OHara |
Subject: |
Re: renaming "vertical spacing inside systems" props |
Date: |
Mon, 08 Nov 2010 19:34:54 -0800 |
User-agent: |
Opera Mail/10.63 (Win32) |
On Mon, 08 Nov 2010 11:14:11 -0800, Mark Polesky <address@hidden> wrote:
Similarly, I think the two 'staff-staff-spacing properties
would be intuitive and easy enough to keep separate,
mentally:
% space between consecutive staves in a system
\override VerticalAxisGroup #'staff-staff-spacing
% space between consecutive staves in a staff-group
\override StaffGrouper #'staff-staff-spacing
Thoughts?
From the users' point of view, your suggestion is a clear improvement. The two
properties have the same form and the same function, so you would spare us the
trouble of remembering that they are the same.
But before folding two property names together, you should search for uses of
the old names, to check whether the code ever assumes that any object with a
'between-staff-spacing' must be StaffGrouper, or if it ever assumes that
anything with a 'next-staff-spacing' must be VerticalAxisGroup. After a git
grep for the two old names, only the function append_system() in
page-layout-problem.cc looked like it might act differently if the names are
merged.
--
Keith
- Re: renaming "vertical spacing inside systems" props, (continued)
- Re: renaming "vertical spacing inside systems" props, Jean-Charles Malahieude, 2010/11/07
- Re: renaming "vertical spacing inside systems" props, David Kastrup, 2010/11/07
- Re: renaming "vertical spacing inside systems" props, Mark Polesky, 2010/11/07
- Re: renaming "vertical spacing inside systems" props, Keith E OHara, 2010/11/07
- Re: renaming "vertical spacing inside systems" props, Mark Polesky, 2010/11/08
- Re: renaming "vertical spacing inside systems" props, David Kastrup, 2010/11/08
- Re: renaming "vertical spacing inside systems" props, Carl Sorensen, 2010/11/08
- Re: renaming "vertical spacing inside systems" props, Trevor Daniels, 2010/11/08
- Re: renaming "vertical spacing inside systems" props, Werner LEMBERG, 2010/11/09
- Re: renaming "vertical spacing inside systems" props, Alexander Kobel, 2010/11/09
- Re: renaming "vertical spacing inside systems" props,
Keith E OHara <=
- Re: renaming "vertical spacing inside systems" props, Carl Sorensen, 2010/11/08
Re: renaming "vertical spacing inside systems" props, Carl Sorensen, 2010/11/07