|
From: | Carl . D . Sorensen |
Subject: | Re: Reorganize language files and add a new \language command. (issue2699041) |
Date: | Wed, 27 Oct 2010 03:23:03 +0000 |
Looks good! See my comments on the UTF-8 characters in the names getting mangled. Thanks, Carl http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly File ly/norsk.ly (right): http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly#newcode4 ly/norsk.ly:4: %%%% Copyright (C) 1998--2010 Arvid Grøtting <address@hidden> Looks like the UTF-8 got mangled here. I think this should say Copyright (C) 2010 Valentin Villenave since none of the code remaining in this file belongs to Arvid. And I think that you should add all of the individual file authors to the formal statement at the top of language-init.ly. And I agree with keeping the authors in the block comments for each language -- but maybe not the copyright statement (since it's at the top of the file). http://codereview.appspot.com/2699041/
[Prev in Thread] | Current Thread | [Next in Thread] |