[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) i
From: |
pnorcks |
Subject: |
Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044) |
Date: |
Wed, 20 Oct 2010 21:58:07 +0000 |
Hi Ian,
I will test your patch shortly.
Thanks,
Patrick
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm
File scm/lily.scm (right):
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode231
scm/lily.scm:231: (_ "Guile 1.8\n")))))
Okay, I can live with this. :)
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode271
scm/lily.scm:271: (debug-enable 'debug)
On 2010/10/20 21:42:06, ianhulin44 wrote:
This causes a deprecation warning from Guile V1.9.13 with
$ declare -x GUILE_WARN_DEPRECATED="detailed"
[/home/ian/lilypond/out/share/lilypond/current/scm/lily.scm]
`(debug-enable 'debug)' is obsolete and has no effect.
Remove it from your code.
Go ahead. There is another instance of `(debug-enable 'debug)' earlier
in this file, so you can remove that too.
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode332
scm/lily.scm:332: (set-module-name! iface (module-name mod))
Please change this so that it uses a tab again.
http://codereview.appspot.com/2219044/diff/15001/scm/lily.scm#newcode338
scm/lily.scm:338: (fresh-interface!))))
This line too.
http://codereview.appspot.com/2219044/
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044), ianhulin44, 2010/10/20
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044), ianhulin44, 2010/10/20
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044),
pnorcks <=
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044), pnorcks, 2010/10/20
- Re: T1247 - Conditionally do (use-modules (ice-9 curried-definitions)) if running with Guile V2, (issue2219044), ianhulin44, 2010/10/27