lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Revised autobeam settings patch (issue1682049)


From: Carl . D . Sorensen
Subject: Revised autobeam settings patch (issue1682049)
Date: Mon, 05 Jul 2010 05:23:40 +0000

Reviewers: ,

Message:
I've posted a new patch for review that has the new autobeaming code.

We now have three properties to control autobeaming:  baseMoment (which
sets the smallest time interval used for defining beaming),
beatStructure (which defines the grouping of baseMoment intervals to
form beats), and beamExceptions (which defines cases where the beaming
rules are not governed by the beat structure, such as in 4/4 where beats
1 and 2 are combined if the notes are all 1/8 notes, but not if they're
triplets or 1/16 notes.

Default values of baseMoment and beatStructure are calculated from the
time signature.  However, users are free to define custom values of
baseMoment and beatStructure for time signatures, and the resulting
definitions will be stored in timeSignatureSettings for use whenever the
time signature is changed.

All of the regressions are successfully passed.

Please review and give me any comments.

THanks,

Carl


Moving to this new structure has greatly simplified

Description:
Revised autobeam settings patch
Eliminate context properties measureGrouping, beatLength, and
beamSettings

Create new context properties baseMoment, beatStructure, and
beamExceptions.

Save time-signature-specific settings in context property
timeSignatureSettings

Do away with virtually all special rules for beaming; the beat structure
now governs almost all autobeaming.

Fix documentation

Please review this at http://codereview.appspot.com/1682049/show

Affected files:
  M Documentation/de/notation/rhythms.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/notation/rhythms.itely
  M Documentation/snippets/new/beam-endings-in-score-context.ly
  M Documentation/snippets/new/beam-grouping-in-7-8-time.ly
  M Documentation/snippets/new/compound-time-signatures.ly
  M Documentation/snippets/new/conducting-signs,-measure-grouping-signs.ly
  M Documentation/snippets/new/fretted-headword.ly
  M Documentation/snippets/new/reverting-default-beam-endings.ly
  M input/regression/auto-beam-beaming-override.ly
  M input/regression/beaming-ternary-metrum.ly
  M input/regression/les-nereides.ly
  M lily/auto-beam-engraver.cc
  M lily/beam-engraver.cc
  M lily/beam-setting-scheme.cc
  M lily/beaming-pattern.cc
  M lily/include/beam-settings.hh
  M lily/include/beaming-pattern.hh
  M lily/measure-grouping-engraver.cc
  M lily/timing-translator.cc
  M ly/bagpipe.ly
  M ly/engraver-init.ly
  M ly/music-functions-init.ly
  M python/convertrules.py
  M scm/auto-beam.scm
  M scm/beam-settings.scm
  M scm/define-context-properties.scm
  M scm/define-music-display-methods.scm
  M scm/lily-library.scm
  M scm/lily.scm
  M scm/music-functions.scm
  A scm/time-signature-settings.scm
  M scripts/musicxml2ly.py





reply via email to

[Prev in Thread] Current Thread [Next in Thread]