[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes
From: |
Richard Gay |
Subject: |
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes |
Date: |
Sat, 17 Apr 2010 00:26:42 +0200 |
On Fri, 16 Apr 2010 00:15:53 +0100, Neil Puttock <address@hidden>
wrote:
> On 13 April 2010 00:28, Richard Gay <address@hidden> wrote:
> > I slightly modified the regression test for the lyric extender
> > towards your example.
> Can you change the docstring for this test so mentions extenders (just
> to make it clear from the text what's being tested)?
Done
> address@hidden,ragged-right,quote]
> +<<
> + \relative c' {
> ...
> +>>
>
> For the examples using \addlyrics, you can remove the << >> block (the
> parser interprets the music + lyrics as simultaneous automatically).
Done (in English and German doc)
> + c2 \grace { c16([ d e f] } g2) f1
>
> newline before f1
Done
> + (include_grace_notes && end_mom->grace_part_ >
> now.grace_part_))
>
> indent
Done (removed a single space in front)
> + && dynamic_cast<Item *>(g)
> + && Note_head::has_interface(g))
>
> space before (g)
Done
In addition to the above I updated the \version number of both
regression tests to "2.13.19". The patch still applies to current git.
Cheers,
Richard
includeGraceNotes-lyrics-syllables-of-grace-notes.patch
Description: Text Data
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/01
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/03
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/10
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/12
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/12
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Graham Percival, 2010/04/13
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/15
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes,
Richard Gay <=
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/18
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Richard Gay, 2010/04/18
- Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes, Neil Puttock, 2010/04/18