[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Enhancement: Page breaking to avoid widow lines
From: |
Joe Neeman |
Subject: |
Re: Enhancement: Page breaking to avoid widow lines |
Date: |
Thu, 21 Jan 2010 12:47:52 -0800 |
On Thu, 2010-01-21 at 13:51 -0500, Boris Shingarov wrote:
> Quoting Joe Neeman <address@hidden>:
>
> > Again, I'd suggest uploading patches to codereview.appspot.com, which
> > provides nice formatting and makes it easy to have multiple reviewers.
>
> Ok, I've created Issue 190102 for this.
>
> One inconvenience that I see with the "upload.py" tool, is that I don't
> see a way to specify the exact target of the diff -- i.e. which files
> to run the diff against, or even make some tweaking to the diff
> contents before submitting them. This is useful because the working
> copy usually contains other, temporary, changes, that I do not want to
> be submitted. In this particular case, there is the workaround for the
> incorrect page height estimation, which got its way into the submitted
> patch because upload.py just grabbed all the changes.
I think the simplest way is to create a new git branch with only the
changes you want to include. Since you'll want to create separate
commits for separate issues anyway, it shouldn't be much extra trouble.
Cheers,
Joe