[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 659: alternate segno symbol (issue181144)
From: |
reinhold . kainhofer |
Subject: |
Re: Issue 659: alternate segno symbol (issue181144) |
Date: |
Mon, 11 Jan 2010 01:05:07 +0000 |
http://www.codereview.appspot.com/181144/diff/1009/29
File lily/span-bar.cc (right):
http://www.codereview.appspot.com/181144/diff/1009/29#newcode204
lily/span-bar.cc:204: else if (type == "S")
On 2010/01/10 20:50:38, Neil Puttock wrote:
You also need to pick up "S."/".S" here, otherwise you'll get a nasty
surprise
between staves ;)
else if (type.find ("S") != NPOS)
AFAICS, Bar_line::compound_barline resets both "S." and ".S" to "S", so
this should be fine. Or am I missing something?
At least the regtest shows the span_bar working correctly for both "S."
and ".S"
http://www.codereview.appspot.com/181144
- Re: Issue 659: alternate segno symbol (issue181144), (continued)
Re: Issue 659: alternate segno symbol (issue181144), n . puttock, 2010/01/07
Re: Issue 659: alternate segno symbol (issue181144), n . puttock, 2010/01/10
Re: Issue 659: alternate segno symbol (issue181144),
reinhold . kainhofer <=
Re: Issue 659: alternate segno symbol (issue181144), n . puttock, 2010/01/11