[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: convert-ly: Normalize versions to three-entry tuples before compari
From: |
john . mandereau |
Subject: |
Re: convert-ly: Normalize versions to three-entry tuples before comparing (issue183097) |
Date: |
Tue, 05 Jan 2010 07:25:56 +0000 |
LGTM if the two nitpicks are adressed.
http://codereview.appspot.com/183097/diff/4/1002
File scripts/convert-ly.py (right):
http://codereview.appspot.com/183097/diff/4/1002#newcode213
scripts/convert-ly.py:213: class InvalidVersion:
this class should be subclassed from a basic Exception class, e.g.
"class InvalidVersion (Exception):". Idem for the two exception classes
défined above, although they aren't normally affected by this patch.
http://codereview.appspot.com/183097/diff/4/1002#newcode323
scripts/convert-ly.py:323: error (_ ("invalid version string `%s' found
in `%s'. \n"
A more common wording of such an error message would be
"%s: %s: invalid version string\n" % (f, ex.version)
or maybe
"%s: invalid version string `%s'\n" % (f, ex.version)
http://codereview.appspot.com/183097
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: convert-ly: Normalize versions to three-entry tuples before comparing (issue183097),
john . mandereau <=