Re: make/doc-i18n-root-rules.make: grep --label=""

[John Mandereau]

Le lundi 28 décembre 2009 à 20:06 +0100, Matthias Kilian a écrit :
> There are two make rules using a command like
> 
>       find $(outdir)/$* -name '*.html' |
>       xargs grep -L --label="" 'UNTRANSLATED NODE: IGNORE ME' | ...
> 
> What's the reason for that `--label=""'? It's breaking the build
> with OpenBSDs native grep (in /usr/bin/grep), and I don't see any
> difference when using GNU grep with and without --label="", so I'd
> like to just drop that option.

The commit that added "--label" is

commit d4401de33195113a8859629b4bd9483a03d9ab5c
Author: Werner Lemberg <address@hidden>
Date:   Thu Dec 14 15:28:27 2006 +0100

(lang-merge): Protect against grep's `(standard input)' output if there is
no input.

It seems to me that the fact there is no input, i.e. that "find
$(outdir) -name '*.html'", is the sign of a build error, so I've removed
--label.  Just in case we need to reintroduce it, or more hopefully for
my curiosity, does your implementation of grep support the option -h
a.k.a. --no-filename?

Best,
John

signature.asc
Description: Ceci est une partie de message numériquement signée