[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Coding style of create-version-itexi.py
From: |
Graham Percival |
Subject: |
Re: Coding style of create-version-itexi.py |
Date: |
Sun, 27 Dec 2009 23:56:06 +0000 |
2009/12/27 John Mandereau <address@hidden>:
> - every tab should be replaced with 4-spaces;
> - "line[0:x] ==" should be replaced with more easy-to-write
> "line.startswith";
> - uncleaned commented code that according to the comment doesn't work
> with Python 2.4.5.
Done.
> - duplicate definition of depth looks like a maintenance nightmare
> similar to the issue Joe just reported on -devel;
That's not an issue; AFAIK the macros won't be used in a normal doc
build. If they are, the depth will either be passed on the
command-line, or derived automatically via some other method.
Cheers,
- Graham