Re: Make define-builtin-markup{,-list}-command #:category #:properties keywords (issue160048)

[nicolas . sceaux]

On 2009/12/17 11:23:04, dak wrote:

> Well, patch set 7 does that, but after rethinking this, I suppose I'd
call it a
> mistake.  Even if the option gets implemented for other constructs
than markup,
> the time and memory savings are likely negligible.  Checking for the
option is
> likely causing more overhead than registering some markup.

Another way to achieve this would have been to do something like

(define index-markup-command
  (if (ly:get-option 'make-index)
      (lambda ...) ;; return code that indexes the commands
      (lambda ...))) ;; return empty code

and then call the index-markup-command function in the
define-markup-command.

> So my take would be to apply patch set 6, and possibly file a TODO
item "just
> index markup, macros, whatever on documentation runs" with low
priority that may
> refer to this discussion and/or patch set 7.

> A complete job would have to mess with indexing in C code if I am not
mistaken.
> And there is no sense in a half-baked job like that of  patch set 7
since markup
> is just a small part of the job.

OK. This issue is not crucial anyway, so I'll commit patch 6 (+ remove
markup-init.ly and its include in declarations-init.ly) as soon as I
have a few minutes (which is probably not today).

Nicolas


http://codereview.appspot.com/160048