Re: PATCH: Refactor script-column.cc for improved reading and fewerlines

[Trevor Daniels]

David Kastrup wrote Friday, December 04, 2009 4:24 PM
> I've unwrapped a bit of code of the form
>
> for (a;b;c) {
>  if (condition)
>    short something
>  else {
>    Large something
>  }
>  z
> }
>
> into
>
> for (a;b;z,c) {
>  if (condition) {
>    short something
>    continue;
>  }
>  Large something
> }
>
> which helps a bit keeping track of what happens where.

I disagree.  Hiding the z in the iteration clause means
it is likely to be overlooked.  Also the use of continue
rather than else does not clarify the structure IMO.

Trevor