lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #


From: David Kastrup
Subject: Re: [PATCH 3/4] Make define-builtin-markup{, -list}-command #:category #:properties keywords
Date: Tue, 24 Nov 2009 06:46:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)

Joe Neeman <address@hidden> writes:

> On Tue, 2009-11-24 at 01:03 +0100, David Kastrup wrote:
>> Carl Sorensen <address@hidden> writes:
>> > IIUC, our policy is that *every* patch that is applied should result
>> > in a buildable LilyPond.  If not, it's a bad patch.
>> 
>> I don't consider this policy prudent in the particular situation "API
>> change implemented with little code" "Wagonloads of changes in API
>> users" because everything within part 1 requires an intensive review,
>> while the much larger part 2 can be skimmed at a much faster pace.
>
> On the other hand, patches which break lilypond make git-bisect much
> less fun.

Uh yes.  Good point.  You got me there.

It appears that the Cc functionality for git-cl was not working, so just
for the record: <URL:http://codereview.appspot.com/160048>.

-- 
David Kastrup





reply via email to

[Prev in Thread] Current Thread [Next in Thread]