Re: Code review/discussion time again.

[David Kastrup]

Han-Wen Nienhuys <address@hidden> writes:

> On Thu, Nov 19, 2009 at 10:20 PM, David Kastrup <address@hidden> wrote:
>>
>> I have no idea what I am doing here.  In particular not with the
>> \override, and the set-object-property!.  Can somebody explain to me
>> just what data structures I happen to manipulate, and how a user is
>> actually _supposed_ to be mangling them?
>
> Perhaps you could explain us how accordion notation works; that will
> make it easier to give advice on how to best achieve your targets.

In the context of _this_ patch, we are just placing register symbols.
The set of symbols that is being used is normally valid per staff.  It
is just in rare cases that you would want to change this set in
mid-staff, with the exception of switching between "Free Bass" and
"Standard Bass" symbols which can be interchanged on one hand.

> As far as I can see, there are 2 settings:
>
> -  the type of accordion (eg defaultStdBassV), which typically span
> multiple notes, or even the entire piece?

There are separate symbol sets for left and right hand, and that of the
left hand may be interchanged in mid-stream.

> - the register of a note.  Is that specific for one note or for
> multiple notes?

Multiple notes.

In a later modification: sometimes you want to set this on a bar line
rather than on the first note.  Likewise, the equivalent of bowing
directions sometimes is set on bar lines (to indicate one direction for
all of the following bars rather than just the next note).

> Given the register of the note and the type of the accordion, you want
> to create a specific symbol on top of a given note, correct?

-- 
David Kastrup