Re: Fixes issue 786, "Extenders in lyrics stop prematurely if a single underscore is found."

[joeneeman]

http://codereview.appspot.com/150067/diff/2003/3005
File lily/extender-engraver.cc (right):

http://codereview.appspot.com/150067/diff/2003/3005#newcode83
lily/extender-engraver.cc:83: }
current_lyric_is_skip_ = ly_is_equal (test, scm_from_locale_string ("
"));

http://codereview.appspot.com/150067/diff/2003/3005#newcode113
lily/extender-engraver.cc:113: if (!melisma_busy (voice) &&
!current_lyric_is_skip_ && lyric_acknowledged_)
Could you please add a sentence or two explaining why this test is here?

http://codereview.appspot.com/150067/diff/2003/3006
File lily/hyphen-engraver.cc (right):

http://codereview.appspot.com/150067/diff/2003/3006#newcode63
lily/hyphen-engraver.cc:63:
current_lyric_is_skip_ = ly_is_equal (text, scm_from_locale_string ("
"))

http://codereview.appspot.com/150067/diff/2003/3007
File lily/lyric-engraver.cc (right):

http://codereview.appspot.com/150067/diff/2003/3007#newcode67
lily/lyric-engraver.cc:67: text_ = make_item ("LyricText",
event_->self_scm ());
Indentation.

Also, please add a comment explaining (at a high level) why we need to
pass empty lyrics to the hyphen and extender engravers.

http://codereview.appspot.com/150067