Re: [PATCH] SVG backend: Output a single SVG file for each page

[Patrick McCarty]

On Thu, Aug 06, 2009 at 12:32:20AM -0700, Graham Percival wrote:
> On Thu, Aug 06, 2009 at 12:29:58AM -0700, Patrick McCarty wrote:
> > The details are listed on the Rietveld page, but I'll illustrate the
> > naming convention here.
> > 
> > 1) One book, four pages (test.ly):
> > 
> >   test.svg
> >   test-page2.svg
> >   test-page3.svg
> >   test-page4.svg
> 
> Speaking as a user, could it detect if there's more than one page,
> and if so, begin naming at test-page-1.svg?

Yes, it could, if I changed the patch.  :-)

BTW, it would be nice if we had this autodetection for multiple \book
blocks too, but that belongs in the different thread.

> > 2) Two books, 3 pages each (test.ly):
> > 
> >   test.svg
> >   test-page2.svg
> >   test-page3.svg
> >   test-1.svg
> >   test-1-page2.svg
> >   test-1-page3.svg
> 
> Again, I'd rather have a uniform set of produced files.  If
> there's more than one book, could it statrt numbering with
> test-1-page-1.svg?

Sure, that's an easy fix.

> > This patch is one of the final steps towards producing SVG
> > output that is both valid and compatible across all user agents
> > I have tested (Inkscape, Firefox, etc.)
> 
> Awesome work!

Thanks!

Here's the new patch:

http://codereview.appspot.com/105045/show


-Patrick