Re: [PATCH] Fix crash when output-preview-framework is missing

[Patrick McCarty]

On Thu, May 28, 2009 at 10:46:11PM +0200, Reinhold Kainhofer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Am Donnerstag, 28. Mai 2009 22:18:23 schrieb Neil Puttock:
> > +   warning (_f ("the `%s' backend does not support -dprint-pages",
> > +                get_output_backend_name ()));
> >
> > +   warning (_f ("the `%s' backend does not support -dpreview",
> > +                get_output_backend_name ()));
> >
> > I'm not sure about these; personally I'd prefer having the important
> > information (the unsupported backend) at the end of the message:
> >
> > "unsupported backend for program option -dpreview: `%s'"
> 
> This way, the explanation "unsupported backend" and the type of backend are 
> very far apart and as such this message is much harder to understand. If you 
> prefer the backend at the end, I would formulate it as:
> 
> Program option -dpreview not supported by backend `%s'.

I like Reinhold's suggestion a little more, so I think we should go
with it.

A new patch with revised warning messages is attached.

Thanks,
Patrick

0001-Fix-crash-when-output-preview-framework-is-missing.patch
Description: latest patch