[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5437 Improve markup->string

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

• Patch: review --> needs_work
• Comment:

As stated on Rietveld, with
https://sourceforge.net/p/testlilyissues/issues/4685/
a glitch was introduced.
While I'm pretty sure the current patch-set cures it, I'm simply not sure whether other bad stuff is introduced - there are so many markup-(list-)commands...
This convinces me, we do need a regtest for markup->string.

So I stop the review for now (setting this to needs-work) and start thinking how such a regtest could be done.

Suggestions are highly appreciated.

---

[issues:#5437] Improve markup->string

Status: Started
Created: Sat Nov 10, 2018 12:48 PM UTC by Thomas Morley
Last Updated: Mon Nov 12, 2018 01:12 PM UTC
Owner: Thomas Morley

Improve markup->string

'all-relevant-markup-commands' is now a toplevel-defined procedure.
So it is not longer a part of the rekursive 'markup->string'.
It needs to be a procedure, because not all bindings of the
lily-module are already done in markup.scm, so it should be
evaluated at the time 'markup->string' is called.
Additionally we gain the chance to have user-defined
markup-commands from '(current-module)' been processed as well.

http://codereview.appspot.com/347000043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto