|
From: | Auto mailings of changes to Lily Issues |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5043 Define markup command \with-outline |
Date: | Thu, 26 Jan 2017 07:32:13 +0000 |
LGTM. It's definitely much cleaner and faster to use something like this than the combination of a transparent box and delayed evaluation that previously was the only solution to get similar results.
Standing upon trifles:
Almost all of the stencil functions return void and modify an existing stencil. One returns a new stencil (in_color), and for one functionality there are two functions ('void translate(...)' and 'Stencil translated(...)'). It would be more consistent to either only define a void function or to provide both, a 'void outlined_with(...)' and a 'Stencil with_outline(...)'.
[issues:#5043] Define markup command \with-outline
Status: Started
Created: Tue Jan 24, 2017 09:22 PM UTC by David Kastrup
Last Updated: Wed Jan 25, 2017 08:46 AM UTC
Owner: David Kastrup
Define markup command \with-outline
Also contains commits:
Use ly:stencil-outline instead of transparent-stencil
Implement ly:stencil-outline separating ink/metrics
http://codereview.appspot.com/319170043
Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |