[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4903 Fold Slur_proto_engraver into Slur_engraver

[Auto mailings of changes to Lily Issues]

• labels: --> Fixed_2_19_45
• status: Started --> Fixed
• Patch: review -->
  
• Type: Enhancement --> Maintainability
• Comment:

Pushed to staging as
commit 01cf114a7808fb0d519d0619f6f56c524ce60399
Author: David Kastrup address@hidden
Date: Mon Jun 20 23:48:14 2016 +0200

Issue 4903/4: Fold Slur_proto_engraver into Slur_engraver

A symmetrical common base class to both Slur_engraver and
Phrasing_slur_engraver seems like an unnecessary complication.  Instead,
Phrasing_slur_engraver can just be derived from Slur_engraver .

commit 509f945ca92d53976bf024d999598cc53b5d1cdd
Author: David Kastrup address@hidden
Date: Mon Jun 20 20:37:46 2016 +0200

Issue 4903/3: Restructure slur engravers

Replaces data members specific to derived classes of Slur_proto_engraver
with virtual functions.

commit 69f2bf94c9f57986769f6371bc63ee27a3e6c095
Author: David Kastrup address@hidden
Date: Tue Jun 21 02:05:54 2016 +0200

Issue 4903/2: {phrasing-,}slur-engraver.cc: adjust includes

commit 6e46bbbd9fb0a138e9f64fcb09b750fb25bc9fe8
Author: David Kastrup address@hidden
Date: Mon Jun 20 23:00:28 2016 +0200

Issue 4903/1: internal_make_grob: Remove unused `name' argument

---

[issues:#4903] Fold Slur_proto_engraver into Slur_engraver

Status: Fixed
Labels: Fixed_2_19_45
Created: Mon Jun 20, 2016 10:49 PM UTC by David Kastrup
Last Updated: Thu Jun 23, 2016 07:30 PM UTC
Owner: David Kastrup

Fold Slur_proto_engraver into Slur_engraver

A symmetrical common base class to both Slur_engraver and
Phrasing_slur_engraver seems like an unnecessary complication. Instead,
Phrasing_slur_engraver can just be derived from Slur_engraver .

Also contains commits:

Restructure slur engravers

Replaces data members specific to derived classes of Slur_proto_engraver
with virtual functions.

internal_make_grob: Remove unused `name' argument

http://codereview.appspot.com/302020043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto