[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignmen
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface |
Date: |
Thu, 26 Jun 2014 18:33:17 +0000 |
Updates:
Labels: -Patch-waiting Patch-new
Comment #67 on issue 3239 by address@hidden: Patch: rewrite
Self_alignment_interface
http://code.google.com/p/lilypond/issues/detail?id=3239#c67
t
rt
C
D
D
C
some cleanup of aligned_on_parent
align textscripts on parent
I think this makes more sense than just "self-alignment".
It makes them consistent with Lyrics and Dynamics.
don't hardcode centering on parent; replace closures with calls to
aligned-on-x-parent
Clean up DynamicText horizontal alignment.
Until now, DynamicText alignment was messy, as there were 3 different
callbacks involved - some of them interacting in a confusing way:
- in define-grobs.scm, X-offset property was initialized to
ly:self-alignment-interface::x-aligned-on-self,
- Dynamic_engraver called set_center_parent on every created
DynamicText, so that half a NoteHead width was always added
to its X-offset (producing confusing results for example when
user requested dynamics to be left-aligned),
- DynamicTexts living in a Dynamics context used a completely
different offset callback, which aligned them on NoteColumns.
Since aligned_on_parent is now able to correctly align grobs
with PaperColumn parents (issue 3254), we can use it for all
DynamicTexts and have a single interface for the job.
Expected changes in output: DynamicTexts in Dynamics context
aligned to suspended noteheads may be placed up to 1/4 NoteHead
width further to the right. This shouldn't be a problem.
http://codereview.appspot.com/105410046
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28
Re: [Lilypond-auto] Issue 3239 in lilypond: Patch: rewrite Self_alignment_interface, lilypond, 2014/06/28