[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lilypond-auto] Issue 3932 in lilypond: Patch: Clean up code for sor
From: |
lilypond |
Subject: |
Re: [Lilypond-auto] Issue 3932 in lilypond: Patch: Clean up code for sorting grob-properties. |
Date: |
Tue, 03 Jun 2014 08:19:14 +0000 |
Updates:
Status: Fixed
Labels: -Patch-push Fixed_2_17_9
Comment #7 on issue 3932 by address@hidden: Patch: Clean up code for
sorting grob-properties.
http://code.google.com/p/lilypond/issues/detail?id=3932
Mark, don't forget to complete the tracker admin.
You commit message is fine for the 'patch verifiers' but I like to give
them some more so I often just cut/paste the commit information thus:
--snip--
author Mark Polesky <address@hidden>
Mon, 2 Jun 2014 22:31:35 +0000 (15:31 -0700)
committer Mark Polesky <address@hidden>
Mon, 2 Jun 2014 22:31:35 +0000 (15:31 -0700)
commit 9bd283b9f1bb5d42138533dfa9a39d6c436da93e
--snip--
Then change the label to
fixed_x_xx
which is a manual label but represents the 'next' version of the code - at
this time that is according to git going to be 2.19.8 (yes we may release
2.20 before that but again it tells historians (so to speak) that it is not
in 2.19.7 and was introduced after that - which helps debugging.
Finally, change the 'status' field to 'Fixed'.
Then the path verifiers can filter their searches for the tracker to then
go through all the patches that have been marked as fixed, use the label
and the commit message to verify it really has been fixed.
I'll do this one for you to show.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings