lilypond-auto
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lilypond-auto] Issue 1412 in lilypond: programming error: Going bac


From: lilypond
Subject: Re: [Lilypond-auto] Issue 1412 in lilypond: programming error: Going back in MIDI time
Date: Thu, 21 Nov 2013 15:54:21 +0000

Updates:
        Status: Started
        Owner: address@hidden
        Labels: Patch-new

Comment #7 on issue 1412 by address@hidden: programming error: Going back in MIDI time
http://code.google.com/p/lilypond/issues/detail?id=1412#c7

Fix spurious error playing initial grace notes (issue 1412).

This happens because the MIDI output starts at tick 0, regardless of when the first event is. Initial grace notes start start at negative ticks, so midi_walker::output_event thinks they're out of order. Fixed by starting at the first event.

Note that if a piece starts with a rest, the first event will be the first note, so we'll now skip the rest. To preserve initial rests, change the last line to:

last_tick_ = items_.empty () ? 0 : min(items_[0]->audio_column_->ticks (), 0);

http://codereview.appspot.com/30360043

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings



reply via email to

[Prev in Thread] Current Thread [Next in Thread]