[Libunwind-devel] libunwind-1.2: mips/mips64 support?

[Randy MacLeod]

Hi,

I have a problem with the libunwind-1.2 tarball:

http://download.savannah.nongnu.org/releases/libunwind/libunwind-1.2.tar.gz

in that the src/mips and src/mips64 directories do not contain the file:
   unwind_i.h
There are MANY other differences as well (see below).
I tried to make sense of this using the repo's git history
but it's not clear what has happened.

Am I doing something wrong or is support for mips* and tilegx
present in the git repo but removed from the tarball release?


The md5sum of the tarball is:
eefcb5d7f78fdc8f1ed172a26ea4202f  libunwind-1.2.tar.gz

Using the 1.2 tarball results in Yocto
(https://www.yoctoproject.org/) cross-compiles for qemumips[64]
failing like this:

   mips-wrs-linux-libtool: compile:  mips-wrs-linux-gcc -meb -mabi=32 \
   -mhard-float -march=mips32r2 \
   --sysroot=\
   /.../tmp/work/mips32r2-wrs-linux/libunwind/1.2-r0/recipe-sysroot \
   -DHAVE_CONFIG_H -I. -I../../libunwind-1.2/src -I../include \
   -I../../libunwind-1.2/include \
   -I../../libunwind-1.2/include/tdep-mips -I. \
   -D_GNU_SOURCE -DNDEBUG -O2 -pipe -g \
   -fno-omit-frame-pointer -fvisibility=default -fexceptions \
   -Wall -Wsign-compare -c ../../libunwind-1.2/src/mi/Lget_reg.c \
   -o mi/Lget_reg.o >/dev/null 2>&1
   In file included from \
   ../../libunwind-1.2/src/mips/Lcreate_addr_space.c:4:0:
   ../../libunwind-1.2/src/mips/Gcreate_addr_space.c:27:22:
   fatal error: unwind_i.h: No such file or directory
    #include "unwind_i.h"
                        ^
   ERROR: oe_runmake failed
   compilation terminated.

Building libunwind for mips works if I fetch the git repo using:

   SRCREV = "bc8698fd7ed13a629a8ec3cb2a89bd74f9d8b5c0"
or
   SRCREV = "0326f1048a0d75ea9498360f60a0c711cd190b7b"
or even master, aka:
   SRCREV = "59ecb24ca29f5e80cf36ec5e216113241cb39480"
   if I just drop all our patches to test the build. :)

fyi, the mips* busted recipe is here:

http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-support/libunwind/libunwind_1.2.bb
and the working one is here:

http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-support/libunwind/libunwind_git.bb?h=pyro

Anyhow, release tarballs are preferred in general and
there have been some git repo outages recently.

Here's how I can show that the mips*/tilegx tarball
is missing unwind_i.h the git repo is not:

$ git checkout 0326f1048a0d75ea9498360f60a0c711cd190b7b
...
$ find * -name unwind_i.h
src/mips/unwind_i.h
src/ppc64/unwind_i.h
src/hppa/unwind_i.h
src/aarch64/unwind_i.h
src/arm/unwind_i.h
src/tilegx/unwind_i.h
src/x86/unwind_i.h
src/sh/unwind_i.h
src/ppc32/unwind_i.h
src/x86_64/unwind_i.h
src/ia64/unwind_i.h

but with the 1.2 tarball:

$ cd .../libunwind-1.2
$ find * -name unwind_i.h
src/ia64/unwind_i.h
src/hppa/unwind_i.h
src/x86/unwind_i.h
src/sh/unwind_i.h
src/arm/unwind_i.h
src/ppc32/unwind_i.h
src/x86_64/unwind_i.h
src/ppc64/unwind_i.h
src/aarch64/unwind_i.h



--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5

Some more diffstats might be helpful; they were done with the repo
checked out to:
   0326f1048a0d75ea9498360f60a0c711cd190b7b

# Just look under 'src' to hide the sensible large Makefile* diffs:
#
$ diff  -Naur ~/tmp/libunwind/libunwind-1.2/src src  |diffstat
 aarch64/gen-offsets.c |   68 
++++++++++++++++++++++++++++++++++++++++++++++++++
 arm/gen-offsets.c     |   54 +++++++++++++++++++++++++++++++++++++++
 coredump/README       |    8 +++++
 hppa/get_accessors.c  |   35 +++++++++++++++++++++++++
 hppa/tables.c         |   43 +++++++++++++++++++++++++++++++
 ia64/NOTES            |   65 
+++++++++++++++++++++++++++++++++++++++++++++++
 ia64/mk_Gcursor_i.c   |   65 
+++++++++++++++++++++++++++++++++++++++++++++++
 ia64/mk_Lcursor_i.c   |    2 +
 ia64/mk_cursor_i      |    7 +++++
 mi/Ldyn-remote.c      |    5 +++
 mips/elfxx.c          |   27 +++++++++++++++++++
 mips/gen-offsets.c    |   30 ++++++++++++++++++++++
 mips/unwind_i.h       |   43 +++++++++++++++++++++++++++++++
 ppc32/Make-arch.in    |   11 ++++++++
 ppc32/setcontext.S    |    9 ++++++
 ppc64/setcontext.S    |    9 ++++++
 setjmp/setjmp.c       |   49 ++++++++++++++++++++++++++++++++++++
 setjmp/sigsetjmp.c    |   50 ++++++++++++++++++++++++++++++++++++
 sh/gen-offsets.c      |   51 +++++++++++++++++++++++++++++++++++++
 tilegx/elfxx.c        |   27 +++++++++++++++++++
 tilegx/gen-offsets.c  |   30 ++++++++++++++++++++++
 tilegx/unwind_i.h     |   44 ++++++++++++++++++++++++++++++++
 x86_64/Ginit.c        |   24 ++++++++++++++++-
 23 files changed, 754 insertions(+), 2 deletions(-)


#full diffstat
$ diff  -Naur ~/tmp/libunwind/libunwind-1.2 .  |diffstat
 .gitignore                 |   69
 INSTALL                    |  365
 LICENSE                    |   18
 Makefile.in                |  911 -
 aclocal.m4                 | 8998 -----------------
 autogen.sh                 |    9
 aux/config.guess           | 1321 ++
 aux/config.sub             | 1443 ++
 aux/ltmain.sh              | 5107 ++++++++++
 config/compile             |  143
 config/config.guess        | 1501 --
 config/config.sub          | 1705 ---
 config/depcomp             |  630 -
 config/install-sh          |  520 -
 config/ltmain.sh           | 8406 ----------------
 config/missing             |  376
 configure                  |22701 
---------------------------------------------
 doc/Makefile.in            |  528 -
 include/config.h.in        |  231
 include/libunwind.h        |   36
 include/tdep/libunwind_i.h |   37
 include/x86/jmpbuf.h       |   31
 libunwind-1.1.tar.gz       | 4278 --------
 libunwind-1.2.tar.gz       | 2985 -----
 scripts/kernel-diff.sh     |   10
 scripts/kernel-files.txt   |   19
 scripts/make-L-files       |   30
 src/aarch64/gen-offsets.c  |   68
 src/arm/gen-offsets.c      |   54
 src/coredump/README        |    8
 src/hppa/get_accessors.c   |   35
 src/hppa/tables.c          |   43
 src/ia64/NOTES             |   65
 src/ia64/mk_Gcursor_i.c    |   65
 src/ia64/mk_Lcursor_i.c    |    2
 src/ia64/mk_cursor_i       |    7
 src/mi/Ldyn-remote.c       |    5
 src/mips/elfxx.c           |   27
 src/mips/gen-offsets.c     |   30
 src/mips/unwind_i.h        |   43
 src/ppc32/Make-arch.in     |   11
 src/ppc32/setcontext.S     |    9
 src/ppc64/setcontext.S     |    9
 src/setjmp/setjmp.c        |   49
 src/setjmp/sigsetjmp.c     |   50
 src/sh/gen-offsets.c       |   51
 src/tilegx/elfxx.c         |   27
 src/tilegx/gen-offsets.c   |   30
 src/tilegx/unwind_i.h      |   44
 src/x86_64/Ginit.c         |   24
 tests/Makefile.am          |    5
 tests/Makefile.in          | 1303 --
 tests/perf-startup         |   19
 53 files changed, 8832 insertions(+), 55659 deletions(-)