[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wc
From: |
Tommi Rantala |
Subject: |
Re: [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wchar test. |
Date: |
Wed, 5 Sep 2012 09:17:54 +0300 |
2012/9/4 Cody P Schafer <address@hidden>:
> ---
> tests/ppc64-test-wchar.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
I wonder what the purpose of this test is, any ideas? Why is libunwind
interested in wchar on ppc64? Is this still relevant?
> diff --git a/tests/ppc64-test-wchar.c b/tests/ppc64-test-wchar.c
> index 01d637c..4506e7f 100644
> --- a/tests/ppc64-test-wchar.c
> +++ b/tests/ppc64-test-wchar.c
> @@ -1,13 +1,13 @@
> #include <wchar.h>
> #include <stdio.h>
> -main ()
> +int main ()
I would use "int main (void)".
> {
> wchar_t *wstring =
How about "static const wchar_t wstring[] =" while we're at it?
> L"Now is the time for all good men to come to the aid of their country";
> - int i;
> + unsigned i;
> int ret;
>
> - printf("wcslen(wstring) = %d\n", wcslen(wstring));
> + printf("wcslen(wstring) = %lu\n", (long unsigned) wcslen(wstring));
> for (i = 0; i < wcslen (wstring); i++)
> {
> ret = printf ("%lc", wstring[i]);
> @@ -17,4 +17,5 @@ main ()
> }
> }
> printf("\n");
> + return 0;
> }
> --
> 1.7.11.3
>
>
> _______________________________________________
> Libunwind-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/libunwind-devel
- [Libunwind-devel] [PATCH 3/7] ppc32: add used attribute to dmy_ctxt, (continued)
- [Libunwind-devel] [PATCH 3/7] ppc32: add used attribute to dmy_ctxt, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 4/7] ppc32: ppc64: test altivec support by running the compiler., Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 5/7] build: make libunwind-coredump build optional, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 1/7] ppc32: ppc64: use AC_COMPILE_IFELSE to test __powerpc64__ macro for ppc64, Cody P Schafer, 2012/09/04
- [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wchar test., Cody P Schafer, 2012/09/04
- Re: [Libunwind-devel] [PATCH 7/7] ppc64: remove compile warnings from wchar test.,
Tommi Rantala <=
- [Libunwind-devel] [PATCH 6/7] configure: use AC_HELP_STRING for configure args instead of manual formating, Cody P Schafer, 2012/09/04