[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libunwind-devel] [PATCH] dwarf: Get correct return from expression eval
From: |
Jiri Olsa |
Subject: |
[Libunwind-devel] [PATCH] dwarf: Get correct return from expression evaluation |
Date: |
Sun, 15 Apr 2012 11:55:50 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
hi,
I hit some issues during unwind and found the typo below,
please consider the fix.
CC me on reply, I'm not on the list
thanks,
jirka
---
Currently the expression evaluation always succeeds,
and possible error is not propagated to the caller.
The ',' operator makes the condition always retun 0.
Signed-off-by: Jiri Olsa <address@hidden>
---
src/dwarf/Gparser.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/dwarf/Gparser.c b/src/dwarf/Gparser.c
index 6793e19..ca26afb 100644
--- a/src/dwarf/Gparser.c
+++ b/src/dwarf/Gparser.c
@@ -785,7 +785,7 @@ apply_reg_state (struct dwarf_cursor *c, struct
dwarf_reg_state *rs)
case DWARF_WHERE_EXPR:
addr = rs->reg[i].val;
- if ((ret = eval_location_expr (c, as, a, addr, c->loc + i, arg)) , 0)
+ if ((ret = eval_location_expr (c, as, a, addr, c->loc + i, arg)) < 0)
return ret;
break;
}
--
1.7.7.6
- [Libunwind-devel] [PATCH] dwarf: Get correct return from expression evaluation,
Jiri Olsa <=