Re: [Libunwind-devel] [PATCHv3 1/4] Add core dump unwinding support to libunwind

[Arun Sharma]

On Thu, Mar 29, 2012 at 9:36 AM, Denys Vlasenko <address@hidden> wrote:

>> The code is also ia64 specific. I don't have any objections to putting
>> it under ia64.
>
>
> It isn't.
>
> Please take a look at src/ptrace/_UPT_find_proc_info.c
> (before patching. Current git, for example).
>
> [..]
> Thus, find_unwind_table exists for all architectures, not only for IA64.
> It just has two different implementations: one for IA64, and another for e

What I meant to say is that for dwarf architectures, having this code
in src/dwarf is just fine. Was suggesting moving just the #ifdef ia64
code to src/ia64.

Like so: 
https://github.com/adsharma/libunwind/commit/9507a9b5018b8be16d2b62531715f1d1e2999f4a

It'd be great if somone with access to ia64 boxes can fix up
compilation and get src/coredump to call dwarf_find_unwind_table vs
ia64_find_unwind_table depending on the architecture (either via
tdep_* macros or a direct ifdef).

 -Arun