|
From: | Ken Werner |
Subject: | Re: [Libunwind-devel] [PATCH] ARM: fix off-by-one in exidx VFP pop |
Date: | Tue, 24 Jan 2012 19:27:54 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 01/24/2012 11:45 AM, Tommi Rantala wrote:
The range of VFP registers we need to pop is inclusive.
Hello Tommi,Thank you for the patch - good catch! This fixes quite an important bug in case VFP registers are involved. I've checked the EHABI document again - your fix looks sane to me. Fortunately the handling of the 1010[0|1]nnn instructions is not affected which means that popping regular registers works just fine (ARM_EXIDX_CMD_REG_POP).
Hi Arun,Is there anything on your side that would prevent the fix from going upstream?
Regards, Ken
[Prev in Thread] | Current Thread | [Next in Thread] |