|Subject:||Re: [Libunwind-devel] ptrace-unwind not working at head|
|Date:||Fri, 19 Feb 2010 11:28:02 +0100|
|User-agent:||Thunderbird 22.214.171.124 (X11/20090817)|
My version seems to be right as well
$ cat /proc/14415/maps
00400000-00616000 r-xp 00000000 08:04 234741 /usr/bin/python2.6
but if you analyze the scan_string function, each time that buf_size is 0, then the return value will be NULL.
Then the second IF guard will be always true.
However, it is right that it needs to skip over the path, but then we need to change the guard from:
if (!cp || dash != '-' || colon != ':')
if (dash != '-' || colon != ':')
do you agreed?
I found 3 leaks, the biggest is in the src/ptrace/_UPT_find_proc_info.c:get_unwind_info() function as you mentioned,
and there are two other minor leaks in the src/dwarf/global.c:dwarf_init(), as I said before, these mempools are never unmapped.
Currently i did a workaround that works for my application (I just unmap the memory before returning get_unwind_info()). Any ideas of where that will be appropriated?
|[Prev in Thread]||Current Thread||[Next in Thread]|