[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Export AIX TLS symbols
|
From: |
Eric Blake |
|
Subject: |
Re: Export AIX TLS symbols |
|
Date: |
Wed, 25 Nov 2015 09:56:14 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/24/2015 09:22 AM, Eric Blake wrote:
> On 11/05/2015 10:43 AM, David Edelsohn wrote:
>> TLS symbols in AIX display a new, different symbol type in nm output.
>> Libtool explicitly creates a list of exported symbols for AIX shared
>> libraries using nm and does not recognize the new TLS symbols, so
>> those symbols are not exported in AIX shared libraries.
>>
>> This is a regression for TLS support on AIX where TLS symbols or GCC
>> "emultls" symbols were listed as global data and exported.
>>
>> This patch updates libtool.m4 export_symbols_cmds for AIX in two
>> locations so that global symbols labeled with "L" for TLS are included
>> in the export list.
>>
>> * m4/libtool.m4 (export_symbols_cmds) [AIX]: Add global TLS "L" symbols.
>>
> I'm not an AIX expert, and have no way to test it, but the explanation
> is reasonable and I don't see how it can hurt (particularly since the
> two changes are under "aix[[4-9]]*)" case blocks).
>
> I'll go ahead and push this patch (assuming my commit rights are still
> active) in 24 hours if no one speaks up to the contrary.
Pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature