Re: Fwd: Fix PIC flags with MPI wrappers using Portland C++ on GNU/Linux

[Brooks Moses]

Christian,

I'm going through old libtool patches that haven't been reviewed, and came 
across this one.  (Sorry that these have been ignored so long.)

On 09/21/2012 10:34 AM, Christian Rössel wrote:
> please find attached a patch that fixes the erroneous detection of PIC
> flags in case when CXX is a MPI wrapper that uses pgCC or pgcpp on
> GNU/Linux as well as the wrong rpath option.

I do have one small question about the patch, before I commit it:
> -           case `$CC -V 2>&1 | sed 5q` in
> +           case `$CC -V 2>&1` in

You make this change in a couple of places where we match verbose compiler 
output looking for (among other things) "*Portland\ Group*".  The "sed 5q" 
simply has the effect of trimming off the first 5 lines of the output and 
ignoring the rest -- presumably to avoid spurious matches to things in later 
output.

Is this change required in order to correctly match the Portland Group 
compilers?  That is, is the expected "*Portland\ Group*" coming somewhere 
after the first five lines?  That seems odd.

The rest of the patch looks good to me, though I'd be curious to see a copy 
of the "$CC -V" output that you're matching.  (In particular, I'd like to 
see output from both pre-version-6 and post-version-6 versions to see how 
the version-matching relates to the expected input.)

Also, thanks for the test reports that you included.

Thanks,
- Brooks