[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_qu
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case. |
Date: |
Fri, 25 Nov 2011 16:14:13 +0700 |
On 21 Nov 2011, at 21:47, Gary V. Vaughan wrote:
> I'll push the whole series in 72 hours or so as usual.
Pushed.
> [[snip]]
>
> Contrary to popular belief, Bourne shell does not resplit case
> expressions after expansion, so if there are no shell unquoted
> shell metacharacters or whitespace, the quotes are useless.
> * cfg.mk (sc_useless_quotes_in_case): New syntax-check rule to
> ensure we don't reintroduce useless quoted case expressions.
> * build-aux/ltmain.m4sh, m4/libtool.m4, tests/bindir.at,
> tests/darwin.at, tests/defs.m4sh, tests/demo-hardcode.test,
> tests/demo-nopic.test, tests/link-2.test, tests/quote.test,
> tests/sysroot.at: Remove spurious quotes.
>
> Signed-off-by: Gary V. Vaughan <address@hidden>
> ---
> build-aux/ltmain.m4sh | 12 ++++++------
> cfg.mk | 8 ++++++++
> m4/libtool.m4 | 2 +-
> tests/bindir.at | 4 ++--
> tests/darwin.at | 2 +-
> tests/defs.m4sh | 2 +-
> tests/demo-hardcode.test | 4 ++--
> tests/demo-nopic.test | 6 +++---
> tests/link-2.test | 2 +-
> tests/quote.test | 8 ++++----
> tests/sysroot.at | 2 +-
> 11 files changed, 30 insertions(+), 22 deletions(-)
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
- Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var., (continued)
Re: [PATCH 6/7] syntax-check: fix violations and implement sc_prohibit_test_const_follows_var., Stefano Lattarini, 2011/11/21
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case., Eric Blake, 2011/11/21
Re: [PATCH 1/7] syntax-check: fix violations and implement sc_useless_quotes_in_case.,
Gary V. Vaughan <=