[PATCH 05/25] syntax-check: fix violations and re-enable sc_error_message_uppercase.

[Gary V. Vaughan]

* cfg.mk (local-checks-to-fix): Remove
sc_error_message_uppercase from list of disabled checks.
(exclude_file_name_regexp--sc_error_message_uppercase): Don't
match cvsu, which is not our file to edit.
* doc/libtool.texi: Use lowercase error message in example.

Signed-off-by: Gary V. Vaughan <address@hidden>
---
 bootstrap        |    3 ++-
 cfg.mk           |    6 ++++--
 doc/libtool.texi |    2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/bootstrap b/bootstrap
index 3755429..9902fd5 100755
--- a/bootstrap
+++ b/bootstrap
@@ -1934,7 +1934,8 @@ $func_strrow_result
 # Echo program name prefixed message to standard error, and exit.
 func_internal_error ()
 {
-    func_fatal_error "INTERNAL: " ${1+"$@"} "
+    func_fatal_error "\
+INTERNAL: " ${1+"$@"} "
           Please report this bug to address@hidden'
           in as much detail as possible."
 }
diff --git a/cfg.mk b/cfg.mk
index 7cb4580..5374f8f 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -63,12 +63,14 @@ local-checks-to-skip =                              \
        $(local-checks-to-fix)                  \
        sc_GPL_version                          \
        sc_bindtextdomain                       \
-       sc_error_message_uppercase              \
        sc_program_name                         \
        sc_unmarked_diagnostics
 
 # GPL_version: checks for GPLv3, which we don't use
 # bindtextdomain: libtool isn't internationalized
-# error_message_uppercase: we like our error messages
 # program_name: libtool has no programs!
 # unmarked_diagnostics: libtool isn't internationalized
+
+# List syntax-check exempted files.
+exclude_file_name_regexp--sc_error_message_uppercase = \
+  ^$(_build-aux)/cvsu$$
diff --git a/doc/libtool.texi b/doc/libtool.texi
index 20292ab..d96e66d 100644
--- a/doc/libtool.texi
+++ b/doc/libtool.texi
@@ -4635,7 +4635,7 @@ This function allows you to integrate your own error 
messages into
 If the allocation of an identifier fails, this function returns -1.
 
 @example
-int myerror = lt_dladderror ("Doh!");
+int myerror = lt_dladderror ("doh!");
 if (myerror < 0)
   perror (lt_dlerror ());
 @end example
-- 
1.7.7.3

Cheers,
-- 
Gary V. Vaughan (gary AT gnu DOT org)