[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/11] build: make better use of automatic variables in `M
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'. |
Date: |
Thu, 23 Sep 2010 20:48:03 +0200 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Gary,
this isn't a review, I'm just adding a couple of hints that come to
mind at first glance.
* Gary V. Vaughan wrote on Thu, Sep 23, 2010 at 05:21:24PM CEST:
> Rules are getting shorter and more readable again now. I'm assuming
> there are no portability problems with "$@" and "$^" in regular rules?
$@ is portable. $^ is not portable.
These things are all documented. Here's the Posix page for make:
<http://www.opengroup.org/onlinepubs/9699919799/utilities/make.html>
here are the Autoconf manual sections about portable make:
<http://www.gnu.org/software/autoconf/manual/html_node/Portable-Make.html>
> If there are, at least keeping this change in a separate patch makes
> it easy enough to omit or amend.
Thanks. Please amend and resubmit, I will review then.
> Now that these rules are all executing from the build tree, there's
> no need to manually check all the paths match the current directory,
> or keep long hand-typed duplicate paths scattered around. We can
> use $@ (and $^ in some places) knowing that they're still correct
> when we've stayed in the same directory they were calculated for.
>
> Okay to push?
>
> * Makefile.am (libtoolize, libtoolize.in, libltdl/Makefile.am)
> (libltdl/config/mkstamp, libltdl/config/ltmain.m4sh)
> (libltdl/m4/ltversion.m4, tests/testsuite,.tests/defs.in):
> Make better use of automatic variables.
Cheers,
Ralf
- [PATCH v2 03/11] build: compare `revision' rather than `correctver' in Makefile.am., (continued)
- [PATCH v2 03/11] build: compare `revision' rather than `correctver' in Makefile.am., Gary V. Vaughan, 2010/09/23
- [PATCH v2 04/11] build: avoid unnecessary directory changes in Makefile rules., Gary V. Vaughan, 2010/09/23
- [PATCH v2 05/11] build: factor Makefile.am `m4sh' invocations to LT_M4SH., Gary V. Vaughan, 2010/09/23
- [PATCH v2 06/11] build: name temporary files in `Makefile.am' consistently., Gary V. Vaughan, 2010/09/23
- [PATCH v2 09/11] build: eliminate `ltmain.in' intermediate file., Gary V. Vaughan, 2010/09/23
- [PATCH v2 08/11] build: don't hardcode repeated long paths in Makefile rules., Gary V. Vaughan, 2010/09/23
- [PATCH v2 10/11] build: eliminate superfluous temporary files from `Makefile.am'., Gary V. Vaughan, 2010/09/23
- [PATCH v2 11/11] maint: simplify and improve safety of bootstrap process., Gary V. Vaughan, 2010/09/23
- [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'., Gary V. Vaughan, 2010/09/23
- Re: [PATCH v2 07/11] build: make better use of automatic variables in `Makefile.am'.,
Ralf Wildenhues <=