libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes


From: Paolo Bonzini
Subject: Re: [REBASED PATCH 0/9] Paolo's sysroot patches, rebased plus some fixes
Date: Wed, 28 Jul 2010 23:43:47 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5

On 07/28/2010 07:35 PM, Charles Wilson wrote:


$ diff good-041/inst/lib/liba.la bad-041/inst/lib/liba.la
20c20
< dependency_libs='
-R/usr/src/packages/libtool/git/build-bisect/tests/testsuite.dir/041/foobar'

---
 > dependency_libs=''

$ diff good-041/inst/lib/libb.la bad-041/inst/lib/libb.la
20c20
< dependency_libs='
-R/usr/src/packages/libtool/git/build-bisect/tests/testsuite.dir/041/foobar
/usr/src/packages/libtool/git/build-bisect/tests/testsuite.dir/041/inst/lib/liba.la'

---
 > dependency_libs='
/usr/src/packages/libtool/git/build-bisect/tests/testsuite.dir/041/inst/lib/liba.la
/usr/src/packages/libtool/git/build-bisect/tests/testsuite.dir/041/inst/lib/liba.la'

There you go.  Two problems here

+ func_append newdependency_libs " ${lt_sysroot:+=}$libdir/$name"
+ newdependency_libs="$newdependency_libs ${lt_sysroot:+=}$libdir/$name"

Double line. Actually not covered by new:41.

+ ;;
+      -L*)
+ func_stripname -L '' "$i"
+ func_replace_sysroot "$func_stripname_result"
+ func_append newdeplibs " -L$func_replace_sysroot_result"

s/newdeplibs/newdependency_libs/ -- this was in my patchset too

+ ;;
+      -R*)
+ func_stripname -R '' "$i"
+ func_replace_sysroot "$func_stripname_result"
+ func_append newdeplibs " -R$func_replace_sysroot_result"

s/newdeplibs/newdependency_libs/ -- also in my patchset.

This should fix it.  I'll send an updated patchset soon.

Paolo

Attachment: 0002-fix.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]