[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI m4 quoting in doc examples
From: |
Eric Blake |
Subject: |
FYI m4 quoting in doc examples |
Date: |
Wed, 23 Jan 2008 21:07:29 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
We should encourage proper quoting of m4 macros. For an example of the
types of bugs that improper quoting can cause, note that the underquoted
usage here won't be true until libtool 2.11 (whenever that is :)
m4_define([a],[1])
LT_PREREQ(2.1a)
Since this is documentation only, I'm committing it as obvious.
2008-01-24 Eric Blake <address@hidden>
Add proper quoting to doc examples.
* doc/libtool.texi: Use quotes where appropriate.
(Test descriptions): Fix truncated sentence.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHmA8B84KuGfSFAYARAvz0AKC76yqZ0wvABi3dqMH0sgPet3wv3gCfVJVV
AtiPlA3sbBEWC9K10T7GmAM=
=ZT0L
-----END PGP SIGNATURE-----
Index: doc/libtool.texi
===================================================================
RCS file: /sources/libtool/libtool/doc/libtool.texi,v
retrieving revision 1.237
diff -u -p -r1.237 libtool.texi
--- doc/libtool.texi 17 Jan 2008 05:32:42 -0000 1.237
+++ doc/libtool.texi 24 Jan 2008 04:04:25 -0000
@@ -1878,7 +1878,7 @@ version of Libtool used for @code{LT_INI
error output and exit with failure (exit status is 63). For example:
@example
-LT_PREREQ(@value{VERSION})
+LT_PREREQ(address@hidden)
@end example
@end defmac
@@ -1935,7 +1935,7 @@ out-of-date. In order to do that, add t
@example
LT_INIT
-AC_SUBST(LIBTOOL_DEPS)
+AC_SUBST([LIBTOOL_DEPS])
@end example
and, to @file{Makefile.in} or @file{Makefile.am}:
@@ -2037,7 +2037,7 @@ language support to Libtool.
@example
LT_INIT
-LT_LANG(C++)
+LT_LANG([C++])
@end example
@example
@@ -2453,7 +2453,7 @@ People used to add code like the followi
@cindex LTLIBOBJS
@example
LTLIBOBJS=`echo "$LIBOBJS" | sed 's/\.[^.]* /.lo /g;s/\.[^.]*$/.lo/'`
-AC_SUBST(LTLIBOBJS)
+AC_SUBST([LTLIBOBJS])
@end example
@noindent
@@ -4462,7 +4462,7 @@ if test "x$with_included_ltdl" != "xyes"
LDFLAGS="$LDFLAGS $LIBLTDL"
AC_CHECK_LIB([ltdl], [lt_dladvise_init],
[],
- [AC_MSG_ERROR(installed libltdl is too old)])
+ [AC_MSG_ERROR([installed libltdl is too old])])
LDFLAGS="$save_LDFLAGS"
CFLAGS="$save_CFLAGS"
fi
@@ -4976,7 +4976,7 @@ Check whether we can actually get help f
@item objectlist.test
@pindex objectlist.test
-Check that a nonexistent objectlist file is properly
+Check that a nonexistent objectlist file is properly
@item pdemo-conf.test
@itemx pdemo-exec.test
- FYI m4 quoting in doc examples,
Eric Blake <=