libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Followup patch: compute dirname and basename at once, when both are


From: Ralf Wildenhues
Subject: Re: Followup patch: compute dirname and basename at once, when both are needed
Date: Thu, 12 Jul 2007 09:24:59 +0200
User-agent: Mutt/1.5.16 (2007-07-04)

Hi Charles,

* Charles Wilson wrote on Thu, Jul 12, 2007 at 08:33:42AM CEST:
> When reviewing one of my earlier patches, Ralf said:
>> Side note: there should be a function that does both dirname and
>> basename at once, for speed.  (Not in this patch, but later.)
>> Another instance below.
>
> This patch adds that new function, and adjusts several locations to take 
> advantage of it.  Tested on cygwin and linux with no regressions.

The libtool.m4 part of this patch also needs an instance of the function
in case the shell does not support XSI extensions.  Inside that
function, you could make use of the other ones (func_dirname and
func_basename) if it helps.  Testing on Solaris with /bin/sh should
expose this.

> I deliberately re-used the same return variables as func_dirname() and 
> func_basename() to minimize ripple, and so that this combo function could 
> be a drop-in replacement for calls to the two separate funcs.

Nice.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]