Re: Fix the locale issue

[Gary V. Vaughan]

Hallo Ralf,

Ralf Wildenhues wrote:
> This patch restores the environment for mode=execute.  Unfortunately,
> it also means more overhead for every libtool invocation.  :-(
> (At least no fork&exec.)

Negligible time overhead... but an unfortunate ugliness all the same.

> OK to apply?

Yes, nice fix, thankyou!

> I think sometime post-2.0 I will want to throw out AS_SHELL_SANITIZE
> again, trade that in for AS_BOURNE_COMPATIBLE and some hand-written
> parts: most of the overhead is lost in this initialization. :(

LT_SHELL_SANITIZE eh? :-)  Agreed.

> And we really have the chance to do that portably: we can detect $unset,
> basename, and dirname and such all at configure time, not needing this
> at runtime.  And then we can go back to saving/restoring only those
> locale variables that we care about: now AS_SHELL_SANITIZE overwrites
> them all, so we _have_ to store them all.
> 
> I am thinking a bit, though, whether there is something we could get
> Autoconf to do, before their next release (so we don't have to wait
> three years until we can use features from their next but one release).

ACK.  It would be nice to push the solution back into Autoconf so that
everyone can benefit from it.

Cheers,
        Gary.

>       * libltdl/config/ltmain.m4sh (startup): save all locale specific
>       environment, variables:, LANG, LANGUAGE, LC_ADDRESS, LC_ALL
>       LC_COLLATE, LC_CTYPE, LC_IDENTIFICATION, LC_MEASUREMENT,
>       LC_MESSAGES LC_MONETARY, LC_NAME, LC_NUMERIC, LC_PAPER,
>       LC_TELEPHONE, LC_TIME.
>       (func_mode_execute): Restore them.

-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature