Re: PGI Compiler patch for cygwin

[Christopher Hulbert]

On 2/24/06, Eric Blake <address@hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> According to Christopher Hulbert on 2/22/2006 5:56 AM:
> >
> > Actually it seems the problem is that a unix-style path is passed to
> > lib as the library name. This is probably not the correct fix, but
> > what I did was add the following to the func_extract_archives function
> > between the *-darwin* and * case.
> >       *-cygwin*)
> >         my_xdir=`cygpath -m $my_xdir`
> >         my_xabs=`cygpath -m $my_xabs`
> >         func_extract_an_archive "$my_xdir" "$my_xabs"
> >         ;;
>
> Missing some proper quoting - consider if my_xabs contained something like
> '/dir with 2  spaces/file'.  Furthermore, I don't think this should this
> be done globally for cygwin because it penalizes compilers that do
> understand POSIX paths (gcc).  When using cygwin as a compilation
> environment, but targetting a compiler that does not understand POSIX
> paths, it is usually better to wrap the compiler inside a script that does
> the command-line conversion, and use that script as the compiler.  So you
> were correct that it is not the correct fix, but it is a good indication
> of the problem that needs to be resolved.

Correct, I'm not familiar enough with all the details and
repurcussions which is why I indicated it probably was not a proper
fix, but did the job for my particular case which should indicate to
the persons who do know the details to create the proper fix :)!

I don't know if I like wrapping the compiler in script or I'm not
fully understanding what you are saying.  I guess if it's transparent
to the user compiling the code it's not a big deal, but I think a
better solution would be to have a test when in the cygwin environment
for posix path acceptance.  This could easily be done by trying to
compile a simple test source file in the compiler's language where the
compile line used the absolute posix path which would either fail or
pass.

Chris

>
> - --
> Life is short - so eat dessert first!
>
> Eric Blake             address@hidden
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (Cygwin)
> Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFD/w9L84KuGfSFAYARAreSAJ951956g75zOA+4VOy1D7ejXLOX5wCgvzj0
> Oz2Q8wFWaDHgHs74Bzkefs0=
> =k4Ov
> -----END PGP SIGNATURE-----
>