libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

deplibs_check_method=test_compile (was: new keywords for testsuite)


From: Ralf Wildenhues
Subject: deplibs_check_method=test_compile (was: new keywords for testsuite)
Date: Fri, 3 Feb 2006 20:18:08 +0100
User-agent: Mutt/1.5.9i

* Ralf Wildenhues wrote on Tue, Jan 31, 2006 at 02:56:49PM CET:
> With this patch, and the fixes in CVS Autoconf's autotest macros,
> it is possible to do neat things..

 ..and if you try it with `deplibs_check_method=test_compile', then
you will note spurious errors during linking.  This mostly trivial
patch fixes them.  OK to apply?

Cheers,
Ralf

        * libltdl/config/ltmain.m4sh (func_mode_link) < test_compile >:
        Fix a couple of instances where `test .. -ne ..' would possibly
        compare non-numbers.  Clean up a bit.

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.32
diff -u -r1.32 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  30 Jan 2006 20:20:54 -0000      1.32
+++ libltdl/config/ltmain.m4sh  31 Jan 2006 13:59:03 -0000
@@ -4592,13 +4640,12 @@
          int main() { return 0; }
 EOF
          $opt_dry_run || $RM conftest
-         $LTCC $LTCFLAGS -o conftest conftest.c $deplibs
-         if test "$?" -eq 0 ; then
+         if $LTCC $LTCFLAGS -o conftest conftest.c $deplibs; then
            ldd_output=`ldd conftest`
            for i in $deplibs; do
              name=`expr $i : '-l\(.*\)'`
              # If $name is empty we are operating on a -L argument.
-             if test "$name" != "" && test "$name" -ne "0"; then
+             if test "$name" != "" && test "$name" != 0; then
                if test "X$allow_libtool_libs_with_static_runtimes" = "Xyes" ; 
then
                  case " $predeps $postdeps " in
                  *" $i "*)
@@ -4635,11 +4682,9 @@
            for i in $deplibs; do
              name=`expr $i : '-l\(.*\)'`
              # If $name is empty we are operating on a -L argument.
-             if test "$name" != "" && test "$name" != "0"; then
+             if test "$name" != "" && test "$name" != 0; then
                $opt_dry_run || $RM conftest
-               $LTCC $LTCFLAGS -o conftest conftest.c $i
-               # Did it work?
-               if test "$?" -eq 0 ; then
+               if $LTCC $LTCFLAGS -o conftest conftest.c $i; then
                  ldd_output=`ldd conftest`
                  if test "X$allow_libtool_libs_with_static_runtimes" = "Xyes" 
; then
                    case " $predeps $postdeps " in
@@ -4671,7 +4716,7 @@
                  droppeddeps=yes
                  $ECHO
                  $ECHO "*** Warning!  Library $i is needed by this library but 
I was not able to"
-                 $ECHO "***  make it link in!  You will probably need to 
install it or some"
+                 $ECHO "*** make it link in!  You will probably need to 
install it or some"
                  $ECHO "*** library that it depends on before this library 
will be fully"
                  $ECHO "*** functional.  Installing it before continuing would 
be even better."
                fi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]