libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: simplify libtoolize path fiddling [libtool--gary--1.0--patch-11]


From: Ralf Wildenhues
Subject: Re: simplify libtoolize path fiddling [libtool--gary--1.0--patch-11]
Date: Fri, 25 Mar 2005 11:31:21 +0100
User-agent: Mutt/1.4.1i

Hi Gary,

* Gary V. Vaughan wrote on Thu, Mar 24, 2005 at 06:16:33PM CET:
> 
> Okay to commit?
> 
>       Most of the hair introduced ostensibly to enable testing of
>       uninstalled libtoolize isn't necessary if we allow overriding of
>       the libtool master copy directory:
> 
>       * configure.ac (pkvmacrodir): No need to substitute this.
>       * Makefile.am (edit): No need to substitute pkgvmacrodir.
>       (dist_pkgvdata_DATA): Use nobase_ prefix so that these files are
>       installed to $(pkgvdatadir)/config.

Not sure if this will upset people as yet-another backwards
incompatibility.  Not if they use `libtoolize', that is.

>       (pkgvmacro_DATA): Renamed to...
>       (nobase_pkgvdata_DATA): ...this, so that files are installed to
>       $(pkgvdatadir)/m4.

So this tells me your patch is against HEAD.  Please write that upfront
so I don't need to kill my branch-2-0 tree.  Thank you.  (I previously
thought libtool--gary--1.0 was branch-2-0 and libtool--devo was HEAD?)

This is also still pending the decision whether to put the m4 files back
to where aclocal can find them, right?  Will that break all your nice
simplifications then?

>       (install-data-hook): Adjust.
>       * libtoolize.m4sh: Remove -I processing.
>       (func_filename_path_search): No longer required without -I.
>       Adjust all callers.
>       (pkgvltdldirs, pkgvmacrodirs): Deleted.
>       (pkgvdatadir): Allow overriding from the environment so that we
>       can write tests for uninstalled libtoolize.
>       (func_serial_update, func_ltmain_update, func_config_update):
>       Rename srcdirs parameter to srcdir, and don't call the path_search
>       function anymore.  Adjust all callers.
>       (--install): Don't blindly copy all config files.

It would be nice to see a test case so that one could verify that all of
this works.

Other than above, I noticed that a `make uninstall' leaves quite a
number of files behind -- all of libltdl -- but that is orthogonal to
this patch.

Regards,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]