Re: generate package.m4 correctly on fresh checkout [libtool--gary--1.0--patch-1]

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Fri, Mar 11, 2005 at 05:16:06PM CET:
> 
> Okay to commit?

I have a couple of questions and comments here: First, I'm uneasy with
more and more stuff being built by `bootstrap' (which should ideally be
empty or as small as possible).  Why can't we generate testsuite from
`make'?  (It might just be me that forgot some point here.)
Failing that, why not create an empty stub and touching a prerequisite
at the end so `make' will update package.m4?

Aside, if bootstrap continues to grow (in size and importance), I think
it should also be made more portable.  Like use of
  : ${AUTORECONF=autoreconf}
  : ${MAKE=make}

  env VAR1=val ... $MAKE tgts..

What do you think?

And finally, returning to the patch: I could not reproduce the bootstrap
failure on linux/GNU make.  Where does it fail?

Regards,
Ralf

>       * bootstrap: Need to generate tests/package.m4 from Makefile.am
>       before generating tests/testsuite from tests/Makefile.am, or
>       else bootstrap of a fresh checkout fails.


> --- orig/bootstrap
> +++ mod/bootstrap
> @@ -1,7 +1,7 @@
>  #! /bin/sh
>  # bootstrap -- Helps bootstrapping libtool, when checked out from CVS.
>  #
> -# Copyright (C) 2003, 2004 Free Software Foundation
> +# Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc,
>  #
>  # This program is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -70,12 +70,15 @@
>  rm -f ./config/ltmain.sh ./m4/ltversion.m4
>  
>  make ./config/ltmain.sh ./m4/ltversion.m4 ./libtoolize.in ./tests/defs.in \
> -    top_srcdir=. PACKAGE="$2" VERSION="$3" M4SH="autom4te --language=m4sh"
> +    srcdir=. top_srcdir=. PACKAGE="$2" VERSION="$3" \
> +    M4SH="autom4te --language=m4sh"
>  
>  {
> +  make update-package-m4 srcdir=. top_srcdir=. \
> +    PACKAGE="$2" VERSION="$3" PACKAGE_BUGREPORT="address@hidden"
>    cd tests
>    make ./testsuite AUTOTEST="autom4te --language=autotest" \
> -    top_srcdir=.. PACKAGE="$2" VERSION="$3" 
> PACKAGE_BUGREPORT="address@hidden"
> +    srcdir=. top_srcdir=.. top_builddir=..  PACKAGE="$2" VERSION="$3"
>    cd ..
>  }
>  
>