Re: FYI: use `&&' to separate commands in the untar process [libtool--release--2.0--patch-56]

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Fri, Mar 11, 2005 at 12:02:53PM CET:
> Ralf Wildenhues wrote:
> > * Gary V. Vaughan wrote on Thu, Mar 10, 2005 at 09:58:58PM CET:
> > 
> >>Applied to branch-2-0 (I didn't make this oversight in the other branches).
> >>
> >>  from  Gary V. Vaughan  <address@hidden>
> >>    * libltdl/Makefile.am (install-data-local): Use `&&' to separate
> >>    commands so that stdin reaches the untar pracess.
> >>    * libltdl/loaders/Makefile.am (install-data-local): Ditto.
> >>    * libtoolize.m4sh (func_copy_cb): Ditto.
> > 
> > 
> > I did not know this was not portable.  Which shell/system is this?
> 
> Bash-2.05b on darwin 7.8.0.  It seems to work in the trivial case:
> 
*snip "trivial cases"*
> 
> And yet:
> 
>   $ cd libltdl
>   $ sed 's,umask 0 &&,umask 0;,' Makefile > tmp && mv tmp Makefile
>   $ make install
>   ...
>   ( cd ../../libltdl && /bin/sh
>   /Users/gary/devel/savannah/libtool--devo--1.0/config/missing --run tar chf -
>   COPYING.LIB README Makefile.am Makefile.in configure.ac configure ltdl.c
>   ltdl.h lt_error.c libltdl/lt_error.h libltdl/lt__private.h
>   libltdl/lt__strl.h libltdl/lt_system.h lt__alloc.c libltdl/lt__alloc.h
>   libltdl/lt__glibc.h libltdl/lt__dirent.h slist.c libltdl/slist.h
>   lt_dlloader.c libltdl/lt_dlloader.h loaders/preopen.c lt__dirent.c
>   libltdl/lt__dirent.h lt__strl.c libltdl/lt__strl.h argz_.h argz.c; ) \
>   | ( umask 0; cd /Users/gary/+inst/share/libtool-2.1a/libltdl &&
>   /bin/sh /Users/gary/devel/savannah/libtool--devo--1.0/config/missing
>   --run tar xf -; )
>   tar: configure: Cannot stat: (null)
>   tar: Error exit delayed from previous errors
>   gnutar: configure: Cannot stat: (null)
>   gnutar: Error exit delayed from previous errors
>   gtar: configure: Cannot stat: (null)
>   gtar: Error exit delayed from previous errors
>   tar: configure: Cannot stat: (null)
>   tar: Error exit delayed from previous errors
>   WARNING: I can't seem to be able to run `tar' with the given arguments.
>            You may want to install GNU tar or Free paxutils, or check the
>            command line arguments.

I get the same thing with `&&' or `;' here..

| ( cd ../../libltdl && /bin/sh 
"/mount/endor/wildenhu/download/software/libtool/write/libtool/config"/missing 
--run tar chf - COPYING.LIB README  Makefile.am Makefile.in  configure.ac 
configure  ltdl.c ltdl.h  lt_error.c libltdl/lt_error.h  libltdl/lt__private.h  
libltdl/lt__strl.h  libltdl/lt_system.h  lt__alloc.c libltdl/lt__alloc.h  
libltdl/lt__glibc.h  libltdl/lt__dirent.h  slist.c libltdl/slist.h  
lt_dlloader.c libltdl/lt_dlloader.h loaders/preopen.c  lt__dirent.c 
libltdl/lt__dirent.h  lt__strl.c libltdl/lt__strl.h  argz_.h argz.c; )  | ( 
umask 0 && cd 
/mount/endor/wildenhu/download/software/libtool/install/libtool-2.1/share/libtool-2.1a/libltdl
 && /bin/sh 
"/mount/endor/wildenhu/download/software/libtool/write/libtool/config"/missing 
--run tar xf -; )
| tar: configure: Cannot stat: No such file or directory
| tar: Error exit delayed from previous errors
| gtar: configure: Cannot stat: No such file or directory
| gtar: Error exit delayed from previous errors
| tar: configure: Cannot stat: No such file or directory
| tar: Error exit delayed from previous errors
| WARNING: I can't seem to be able to run `tar' with the given arguments.
|          You may want to install GNU tar or Free paxutils, or check the
|          command line arguments.

for the very simple reason that there is no `configure' in libltdl
because we eliminated configuring in there some time ago.  So: Is
there an actual problem w.r.t. `&&' vs `;'?  Did `make install'
work for you before?  Why?

OK to apply patch below?

> Does bash behave differently when invoked as /bin/sh?

Yes, it does.  But that has nothing to do with our problem here, I
think.

Regards,
Ralf

Index: libltdl/Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/Makefile.am,v
retrieving revision 1.77
diff -u -r1.77 Makefile.am
--- libltdl/Makefile.am 11 Mar 2005 11:39:28 -0000      1.77
+++ libltdl/Makefile.am 11 Mar 2005 12:34:04 -0000
@@ -69,7 +69,7 @@
 ltdldatadir            = $(pkgvdatadir)/libltdl
 ltdldatafiles          = COPYING.LIB README \
                          Makefile.am Makefile.in \
-                         configure.ac configure \
+                         configure.ac \
                          $(libltdl_la_SOURCES) \
                          lt__dirent.c libltdl/lt__dirent.h \
                          lt__strl.c libltdl/lt__strl.h \