FYI: support for linux-dietlibc

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Sun, Nov 28, 2004 at 10:37:08PM CET:
> Ralf Wildenhues wrote:
> >OK to apply the following two patches to HEAD and branch-2-0?
> >With these and the other patches I sent, I get for branch-2-0:
> 
> >patch #1:
> >Detect static dietlibc.  One could think about trying to map `-static'
> >and `-shared' to `diet' and `diet-dyn' respectively, but I figured that
> >isn't worth the effort (I don't think you're supposed to mix these
> >anyway).
> 
> Okay, with one nit, below:
> 
*snip*
> 
> The line splitting here is awkward, my preference is for && and || at
> the beginning of a line:
> 
>   if $LD --help 2>&1 | $EGREP ': supported targets:.* elf' > /dev/null \
>      && test "$tmp_diet" = no
>   then
> 
> because it is easier to see which lines are continuations of the
> previous line when scanning the left columns (or the line ends,
> which is, I think, rarer).  Also I prefer to put the `then' on
> its own line when the condition is multi-lined to put a visual
> pause between the condition and the branch code.  It probably
> isn't consistent throughout libtool's code, but I've been writing
> shell code like this for a lot of years.  Unless you disagree,
> I'll add something to the HACKING file to this effect.

No (I don't disagree).  A note in HACKING would probably be useful.

> >patch #2:
> >
> >     * libltdl/ltdl.c (trim): Use memcpy instead of strncpy here, to
> >     avoid problems with non-conforming strncpy.  This is safe here.
> 
> Looks good to me.

Great.  Both applied (with proposed changes plus NEWS entries) to HEAD
and branch-2-0.

Regards,
Ralf