Re: make libtool faster v1

[Gary V. Vaughan]

Hallo Ralf!

Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Mon, Nov 29, 2004 at 02:11:30PM CET:
> 
>>Ralf Wildenhues wrote:
>>>The patch below is against HEAD, though I'd really like to backport to
>>>branch-2-0 and branch-1-5 as well.
>>
>>branch-1-5 is stable at the moment, so only bug fixes can go there.
> 
> 
> Actually, I'd go as far as calling a 40% speed increase a bugfix, but
> that may only be me (and maybe the gcc folks).

Changing the way the code works (even where it improves the code
significantly) isn't something I would like to see on a stable
branch.

> Err, you do realise there are almost no places in libtool shell code
> with your linesplitting and almost hundred the other way round?  I
> don't care much which style we choose, just wanted to mention
> existing practise to the contrary.

Yes, I am guilty of following the same style as the surrounding
code.  But since libtoolize is doing it the "right" way now
(although I cheated in a few places to stay inside 80 columns),
I wanted to float the idea of standardising.

I'll post a patch and a HACKING entry shortly.

> OK to commit this to HEAD?

Looks good.  Thanks!

> 2004-11-29  Ralf Wildenhues <address@hidden>
> 
>       * config/ltmain.m4sh (func_lalib_p): Update function
>       description. (func_lalib_unsafe_p): New function with same
>       functionality but written without forks; this function is safe
>       to use for cases where the argument either does not exist or
>       is required to be a lalib for correct operation.
>       * NEWS: Mention that stdin is not to be used.
>       * (func_mode_execute, func_mode_install, func_mode_link):
>       Use func_lalib_unsafe_p where appropriate.
>       * (func_mode_execute): For the program wrapper, use
>       func_ltwrapper_p instead of func_lalib_p.

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature