Another cygwin cleanup patch

[Charles Wilson]

Another cleanup patch from Peter...I haven't tested it, but it contains 
simple, obvious fixes.

2004-11-01  Peter Ekberg  <spam.protected>

        * ltmain.m4sh (cwrappersource): clean up warnings and
        #include errors.

--
Chuck


-------- Original Message --------
Subject: RE: Avail for test: libtool-devel-1.9f_20041024-1, 
libltdl6-1.9f_20041024-1
Date: Mon, 1 Nov 2004 14:59:03 +0100
From: Peter Ekberg
Newsgroups: gmane.os.cygwin

Chuck wrote:
> New alpha versions of libtool available for test.  This is
> very close to what libtool-2.0 will be.  Please evaluate.

Ok, I found another problem. You cannot add the flag
-Werror-implicit-function-declaration to CFLAGS as that
kills the build of the wrapper executable. While there,
clean up some other warnings as well, so that -Werror
also has a chance to work...

Here's the make output without the patch:

/bin/sh ../libtool --mode=link --tag=CC gcc  -g -O2 -D_REENTRANT
-D_THREAD_SAFE -DDEBUG -g -Wall -Wpointer-arith -Wsign-compare
-Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type -Wshadow
-Wnested-externs -Wredundant-decls -Werror-implicit-function-declaration
-o demo.exe  demo.o ../gii/libgii.la
gcc -g -O2 -D_REENTRANT -D_THREAD_SAFE -DDEBUG -g -Wall -Wpointer-arith
-Wsign-compare -Wstrict-prototypes -Wswitch -Wmissing-prototypes
-Wreturn-type -Wshadow -Wnested-externs -Wredundant-decls
-Werror-implicit-function-declaration -o .libs/demo.exe demo.o
../gii/.libs/libgii.dll.a
/home/peda/ggi2-cygwin/libgii/gg/.libs/libgg.dll.a -lpthread
libtool: link: creating demo.exe
.libs/lt-demo.c:68:1: warning: "DEBUG" redefined
<command line>:11:1: warning: this is the location of the previous
definition
.libs/lt-demo.c: In function `main':
.libs/lt-demo.c:110: warning: control reaches end of non-void function
.libs/lt-demo.c: In function `xstrdup':
.libs/lt-demo.c:125: error: implicit declaration of function `strcpy'
.libs/lt-demo.c:125: error: implicit declaration of function `strlen'
.libs/lt-demo.c: In function `find_executable':
.libs/lt-demo.c:241: error: implicit declaration of function `memcpy'
.libs/lt-demo.c:179: warning: unused variable `st'
.libs/lt-demo.c: In function `strendzap':
.libs/lt-demo.c:288: error: implicit declaration of function `strcmp'

Everything below the "libtool: link: creating demo.exe" line
disappears with the patch.

Cheers,
Peter

win32-wrapper-cleanup.patch
Description: Binary data