Re: Quote AC_DEFUN macro names

[Robert Boehne]

Alexandre,

Approved!  I'll check it in right away.

Robert

Alexandre Duret-Lutz wrote:
> 
> Hi!
> 
> I'd like to suggest this patch for branch-1-4.
> 
> These days I'm running a hacked version of aclocal to detect
> unquoted macro names in AC_DEFUNitions.  These are know to cause
> trouble when someone attempts to redefine them.  (And in the
> future, when Autoconf provides an aclocal replacement, it might
> be the case that several definitions of the same macro are
> temporarily accessible at the same time -- in which case they'd
> better be quoted!)
> 
> 2002-10-22  Alexandre Duret-Lutz  <address@hidden>
> 
>         * ltdl.m4 (AC_LIB_LTDL, AC_LTDL_ENABLE_INSTALL,
>         AC_LTDL_SYS_DLOPEN_DEPLIBS, AC_LTDL_SHLIBEXT, AC_LTDL_SHLIBPATH,
>         AC_LTDL_SYSSEARCHPATH, AC_LTDL_OBJDIR, AC_LTDL_DLPREOPEN,
>         AC_LTDL_DLLIB, AC_LTDL_SYMBOL_USCORE, AC_LTDL_DLSYM_USCORE): Quote
>         macro name in definition.
> 
> Index: ltdl.m4
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/ltdl.m4,v
> retrieving revision 1.21.2.9
> diff -u -r1.21.2.9 ltdl.m4
> --- ltdl.m4     23 Jun 2002 22:48:38 -0000      1.21.2.9
> +++ ltdl.m4     22 Oct 2002 21:17:31 -0000
> @@ -74,7 +74,7 @@
>  # -----------
>  # Perform all the checks necessary for compilation of the ltdl objects
>  #  -- including compiler checks and header checks.
> -AC_DEFUN(AC_LIB_LTDL,
> +AC_DEFUN([AC_LIB_LTDL],
>  [AC_PREREQ(2.13)
>  AC_REQUIRE([AC_PROG_CC])
>  AC_REQUIRE([AC_C_CONST])
> @@ -107,7 +107,7 @@
> 
>  # AC_LTDL_ENABLE_INSTALL
>  # ----------------------
> -AC_DEFUN(AC_LTDL_ENABLE_INSTALL,
> +AC_DEFUN([AC_LTDL_ENABLE_INSTALL],
>  [AC_ARG_ENABLE(ltdl-install,
>  [  --enable-ltdl-install   install libltdl])
> 
> @@ -117,7 +117,7 @@
> 
>  # AC_LTDL_SYS_DLOPEN_DEPLIBS
>  # --------------------------
> -AC_DEFUN(AC_LTDL_SYS_DLOPEN_DEPLIBS,
> +AC_DEFUN([AC_LTDL_SYS_DLOPEN_DEPLIBS],
>  [AC_REQUIRE([AC_CANONICAL_HOST])
>  AC_CACHE_CHECK([whether deplibs are loaded by dlopen],
>         libltdl_cv_sys_dlopen_deplibs, [dnl
> @@ -149,7 +149,7 @@
> 
>  # AC_LTDL_SHLIBEXT
>  # ----------------
> -AC_DEFUN(AC_LTDL_SHLIBEXT,
> +AC_DEFUN([AC_LTDL_SHLIBEXT],
>  [AC_REQUIRE([_LT_AC_LTCONFIG_HACK])
>  AC_CACHE_CHECK([which extension is used for shared libraries],
>    libltdl_cv_shlibext,
> @@ -169,7 +169,7 @@
> 
>  # AC_LTDL_SHLIBPATH
>  # -----------------
> -AC_DEFUN(AC_LTDL_SHLIBPATH,
> +AC_DEFUN([AC_LTDL_SHLIBPATH],
>  [AC_REQUIRE([_LT_AC_LTCONFIG_HACK])
>  AC_CACHE_CHECK([which variable specifies run-time library path],
>    libltdl_cv_shlibpath_var, [libltdl_cv_shlibpath_var="$shlibpath_var"])
> @@ -181,7 +181,7 @@
> 
>  # AC_LTDL_SYSSEARCHPATH
>  # ---------------------
> -AC_DEFUN(AC_LTDL_SYSSEARCHPATH,
> +AC_DEFUN([AC_LTDL_SYSSEARCHPATH],
>  [AC_REQUIRE([_LT_AC_LTCONFIG_HACK])
>  AC_CACHE_CHECK([for the default library search path],
>    libltdl_cv_sys_search_path, 
> [libltdl_cv_sys_search_path="$sys_lib_dlsearch_path_spec"])
> @@ -205,7 +205,7 @@
> 
>  # AC_LTDL_OBJDIR
>  # --------------
> -AC_DEFUN(AC_LTDL_OBJDIR,
> +AC_DEFUN([AC_LTDL_OBJDIR],
>  [AC_CACHE_CHECK([for objdir],
>    libltdl_cv_objdir, [libltdl_cv_objdir="$objdir"
>  if test -n "$objdir"; then
> @@ -227,7 +227,7 @@
> 
>  # AC_LTDL_DLPREOPEN
>  # -----------------
> -AC_DEFUN(AC_LTDL_DLPREOPEN,
> +AC_DEFUN([AC_LTDL_DLPREOPEN],
>  [AC_REQUIRE([AC_LIBTOOL_SYS_GLOBAL_SYMBOL_PIPE])dnl
>  AC_CACHE_CHECK([whether libtool supports -dlopen/-dlpreopen],
>         libltdl_cv_preloaded_symbols, [dnl
> @@ -245,7 +245,7 @@
> 
>  # AC_LTDL_DLLIB
>  # -------------
> -AC_DEFUN(AC_LTDL_DLLIB,
> +AC_DEFUN([AC_LTDL_DLLIB],
>  [LIBADD_DL=
>  AC_SUBST(LIBADD_DL)
> 
> @@ -292,7 +292,7 @@
> 
>  # AC_LTDL_SYMBOL_USCORE
>  # ---------------------
> -AC_DEFUN(AC_LTDL_SYMBOL_USCORE,
> +AC_DEFUN([AC_LTDL_SYMBOL_USCORE],
>  [dnl does the compiler prefix global symbols with an underscore?
>  AC_REQUIRE([AC_LIBTOOL_SYS_GLOBAL_SYMBOL_PIPE])dnl
>  AC_MSG_CHECKING([for _ prefix in compiled symbols])
> @@ -331,7 +331,7 @@
> 
>  # AC_LTDL_DLSYM_USCORE
>  # --------------------
> -AC_DEFUN(AC_LTDL_DLSYM_USCORE,
> +AC_DEFUN([AC_LTDL_DLSYM_USCORE],
>  [AC_REQUIRE([AC_LTDL_SYMBOL_USCORE])dnl
>  if test x"$ac_cv_sys_symbol_underscore" = xyes; then
>    if test x"$ac_cv_func_dlopen" = xyes ||
> 
> --
> Alexandre Duret-Lutz
> 
> _______________________________________________
> Libtool-patches mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/libtool-patches