Re: [PATCH] $linkopts vs. $linker_flags ?

[Gary V . Vaughan]

Hi Brad,

Good catch, thanks.  Applied to HEAD.

In the future, please send patches to address@hidden so that the 
other maintainers can also evaluate them...  after all, I might be struck by 
lightning tomorrow, and then your patch would be dropped ;-)

Cheers,
        Gary.

On Sunday 05 August 2001 3:52 am, you wrote:
> Tell me I'm not mistaken, I see only 3 places where $linkopts is still
> referenced (I don't see it used in ltmain.in) ... I beleive these are
> leftovers from back in libtool 1.3 days ? they should be changed to
> $linker_flags ? This affects a few targets in both HEAD and 1.4.
> This patch is against HEAD.
>
> // Brad
>
> address@hidden
> address@hidden
>
> --- libtool.m4.orig   Fri Aug  3 23:44:26 2001
> +++ libtool.m4        Sat Aug  4 22:42:17 2001
> @@ -4409,7 +4409,7 @@
>        # FIXME: Relying on posixy $() will cause problems for
>        #        cross-compilation, but unfortunately the echo tests do not
>        #        yet detect zsh echo's removal of \ escapes.
> -      _LT_AC_TAGVAR(archive_cmds, $1)='$CC $(test .$module = .yes && echo
> -bundle || echo -dynamiclib) $allow_undefined_flag -o $lib $libobjs
> $deplibs$linkopts -install_name $rpath/$soname $(test -n "$verstring" -a
> x$verstring != x0.0 && echo $verstring)' +      _LT_AC_TAGVAR(archive_cmds,
> $1)='$CC $(test .$module = .yes && echo -bundle || echo -dynamiclib)
> $allow_undefined_flag -o $lib $libobjs $deplibs$linker_flags -install_name
> $rpath/$soname $(test -n "$verstring" -a x$verstring != x0.0 && echo
> $verstring)' # We need to add '_' to the symbols in $export_symbols first
> #_LT_AC_TAGVAR(archive_expsym_cmds, $1)="$_LT_AC_TAGVAR(archive_cmds, $1)"'
> && strip -s $export_symbols' _LT_AC_TAGVAR(hardcode_direct, $1)=yes
> @@ -4743,7 +4743,7 @@
>        ;;
>
>      newsos6)
> -      _LT_AC_TAGVAR(archive_cmds, $1)='$LD -G -h $soname -o $lib $libobjs
> $deplibs $linkopts' +      _LT_AC_TAGVAR(archive_cmds, $1)='$LD -G -h
> $soname -o $lib $libobjs $deplibs $linker_flags'
> _LT_AC_TAGVAR(hardcode_direct, $1)=yes
>        _LT_AC_TAGVAR(hardcode_libdir_flag_spec, $1)='${wl}-rpath
> ${wl}$libdir' _LT_AC_TAGVAR(hardcode_libdir_separator, $1)=:
> @@ -4851,7 +4851,7 @@
>
>      sysv4)
>        if test "x$host_vendor" = xsni; then
> -        _LT_AC_TAGVAR(archive_cmds, $1)='$LD -G -Bsymbolic -h $soname -o
> $lib $libobjs $deplibs $linkopts' +        _LT_AC_TAGVAR(archive_cmds,
> $1)='$LD -G -Bsymbolic -h $soname -o $lib $libobjs $deplibs $linker_flags'
> _LT_AC_TAGVAR(hardcode_direct, $1)=yes # is this really true??? else
>          _LT_AC_TAGVAR(archive_cmds, $1)='$LD -G -h $soname -o $lib
> $libobjs $deplibs $linker_flags'

-- 
  ())_. Gary V. Vaughan     gary@(oranda.demon.co.uk|gnu.org)
  ( '/  Research Scientist  http://www.oranda.demon.co.uk       ,_())____
  / )=  GNU Hacker          http://www.gnu.org/software/libtool  \'      `&
`(_~)_  Tech' Author        http://sources.redhat.com/autobook   =`---d__/