libtool-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] GNU Libtool branch, master, updated. v2.2.4-34-g739b7e4


From: Ralf Wildenhues
Subject: [SCM] GNU Libtool branch, master, updated. v2.2.4-34-g739b7e4
Date: Thu, 21 Aug 2008 19:07:34 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Libtool".

The branch, master has been updated
       via  739b7e434992c9c6a8412c17202ee8f539cbe2fc (commit)
      from  649567ed497902046abecd01a2fa0c5206d51730 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 739b7e434992c9c6a8412c17202ee8f539cbe2fc
Author: Ralf Wildenhues <address@hidden>
Date:   Thu Aug 21 21:07:16 2008 +0200

    Disallow `-L path', do not misparse it silently.
    
    * libltdl/config/ltmain.m4sh (func_mode_link): Diagnose `-L'
    without argument, and `-L path', i.e., with a space.
    * tests/fail.at (Failure tests): Test for these failures.
    * THANKS: Update.
    Report by Olaf Lenz.
    
    Signed-off-by: Ralf Wildenhues <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                  |    9 +++++++++
 THANKS                     |    1 +
 libltdl/config/ltmain.m4sh |    7 +++++++
 tests/fail.at              |   10 +++++++++-
 4 files changed, 26 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fa04482..a97279d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2008-08-21  Ralf Wildenhues  <address@hidden>
+
+       Disallow `-L path', do not misparse it silently.
+       * libltdl/config/ltmain.m4sh (func_mode_link): Diagnose `-L'
+       without argument, and `-L path', i.e., with a space.
+       * tests/fail.at (Failure tests): Test for these failures.
+       * THANKS: Update.
+       Report by Olaf Lenz.
+
 2008-08-16  Ralf Wildenhues  <address@hidden>
 
        Avoid test failure due to broken dlpreloading of shared library.
diff --git a/THANKS b/THANKS
index 6d00c88..f284d4e 100644
--- a/THANKS
+++ b/THANKS
@@ -111,6 +111,7 @@
   Michael Haubenwallner                address@hidden
   Mike Frysinger               address@hidden
   Nix                          address@hidden
+  Olaf Lenz                    address@hidden
   Olly Betts                   address@hidden
   Patrick Welche               address@hidden
   Paul Eggert                  address@hidden
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 31ed2c7..d1c984c 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -4035,6 +4035,13 @@ func_mode_link ()
       -L*)
        func_stripname '-L' '' "$arg"
        dir=$func_stripname_result
+       if test -z "$dir"; then
+         if test $# -gt 0; then
+           func_fatal_error "require no space between \`-L' and \`$1'"
+         else
+           func_fatal_error "need path for \`-L' option"
+         fi
+       fi
        # We need an absolute path.
        case $dir in
        [\\/]* | [A-Za-z]:[\\/]*) ;;
diff --git a/tests/fail.at b/tests/fail.at
index b12a152..fe38ddc 100644
--- a/tests/fail.at
+++ b/tests/fail.at
@@ -1,6 +1,6 @@
 # fail.at -- test that libtool really fail when it should     -*- Autotest -*-
 #
-#   Copyright (C) 2005 Free Software Foundation, Inc.
+#   Copyright (C) 2005, 2008 Free Software Foundation, Inc.
 #   Written by Ralf Wildenhues, 2005
 #
 #   This file is part of GNU Libtool.
@@ -92,5 +92,13 @@ case $build_libtool_libs in yes)
   ;;
 esac
 
+# Ensure we diagnose '-L path'.
+echo 'int main () { return 0; }' > d.c
+echo 'int foo () { return 0; }' > space-after-L.c
+$CC $CPPFLAGS $CFLAGS -c d.c
+$CC $CPPFLAGS $CFLAGS -c space-after-L.c
+FAIL_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -L space-after-L.$OBJEXT 
-o d d.$OBJEXT])
+FAIL_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $LDFLAGS -o d d.$OBJEXT -L])
+
 m4_popdef([FAIL_CHECK])
 AT_CLEANUP


hooks/post-receive
--
GNU Libtool




reply via email to

[Prev in Thread] Current Thread [Next in Thread]