Re: [libmicrohttpd] Re: HTTP Digest Auth done

[Christian Grothoff]

On Thursday 19 August 2010 13:10:41 Simon Josefsson wrote:
> Christian Grothoff <address@hidden> writes:
> > Hi!
> > 
> > I have more comments ;-).
> > 
> > First, I see that you're using "gcry_md_read" and similar functions for
> > MD5. That's perfect *if* MHD is being build with SSL support.  However,
> > for installations without SSL support we also don't link against
> > libgcrypt.  So configure will need to test for libgcrypt and only enable
> > the code (and add "- lgcrypt" to the LDFLAGS) if libgcrypt was found. 
> > Also, your diffs should typically not include changes to generated files
> > (you send the diff for configure).
> 
> Just a side note, but you could consider using GNU Nettle for crypto
> instead of libgcrypt.  Or gnulib, which happens to have MD5 too, and
> then you avoid another pre-dependency.  Gnulib is good for a lot of
> other things too, of course.

Right, I had thought about using gnulib as well here. Not sure if the 
dependency or the code copying is worse, both have advantages and 
disadvantages.  But MD5 is small, so gnulib may be the best answer.

Happy hacking,

Christian